chore: trim eventNames sent to reporting if length exceeds 50 charact…

…ers (#5171)
rudderlabs · Oct 4, 2024 · 87283c4 · 87283c4
1 parent bf45d23
commit 87283c4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/config/config.yaml b/config/config.yaml
@@ -249,5 +249,3 @@ PgNotifier:
   retriggerCount: 500
   trackBatchInterval: 2s
   maxAttempt: 3
-Reporting:
-  eventNameMaxLength: 0
diff --git a/enterprise/reporting/reporting.go b/enterprise/reporting/reporting.go
@@ -649,7 +649,6 @@ func (r *DefaultReporter) Report(ctx context.Context, metrics []*types.PUReporte
 	}
 	defer func() { _ = stmt.Close() }()
 
-	eventNameMaxLength := config.GetInt("Reporting.eventNameMaxLength", 0)
 	reportedAt := time.Now().UTC().Unix() / 60
 	for _, metric := range metrics {
 		workspaceID := r.configSubscriber.WorkspaceIDFromSource(metric.ConnectionDetails.SourceID)
@@ -663,8 +662,9 @@ func (r *DefaultReporter) Report(ctx context.Context, metrics []*types.PUReporte
 			metric = transformMetricForPII(metric, getPIIColumnsToExclude())
 		}
 
-		if eventNameMaxLength > 0 && len(metric.StatusDetail.EventName) > eventNameMaxLength {
-			metric.StatusDetail.EventName = types.MaxLengthExceeded
+		runeEventName := []rune(metric.StatusDetail.EventName)
+		if len(runeEventName) > 50 {
+			metric.StatusDetail.EventName = fmt.Sprintf("%s...%s", string(runeEventName[:40]), string(runeEventName[len(runeEventName)-10:]))
 		}
 
 		_, err = stmt.Exec(

diff --git a/utils/types/reporting_types.go b/utils/types/reporting_types.go
@@ -21,8 +21,6 @@ const (
 	DefaultReplayEnabled    = false
 )
 
-const MaxLengthExceeded = ":max-length-exceeded:"
-
 const (
 	DiffStatus = "diff"
-Original file line number
+Diff line change
@@ Expand Up / @@ -21,8 +21,6 @@ const ( @@
     	DefaultReplayEnabled    = false
     )
-    const MaxLengthExceeded = ":max-length-exceeded:"
     const (
     	DiffStatus = "diff"
@@ Expand Down @@