Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: message and useridentityaction classes #97

Conversation

vgupta98
Copy link
Contributor

@vgupta98 vgupta98 commented Dec 23, 2024

Description

This PR moves TrackEvent, GroupEvent and ScreenEvent classes to new files. It also moves SetAnonymousIdAction class to a new file.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactor/optimization

Implementation Details

Checklist

  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation (if appropriate).
  • I have ensured that my code follows the project's code style.
  • I have checked for potential performance impacts and optimized if necessary.
  • I have checked the code for security issues.
  • I have updated the changelog (if required).

How to test?

Breaking Changes

Maintainers Checklist

  • The code has been reviewed.
  • CI tests have passed.
  • All necessary documentation has been updated.

Screenshots (if applicable)

Additional Context

@vgupta98 vgupta98 marked this pull request as ready for review December 23, 2024 11:23
@vgupta98 vgupta98 self-assigned this Dec 23, 2024
Copy link
Member

@saikumarrs saikumarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vgupta98 vgupta98 merged commit dd9fecb into develop Dec 25, 2024
2 checks passed
@vgupta98 vgupta98 deleted the refactor/sdk-2577-refactor-message-and-useridentityaction-classes branch December 25, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants