feat: lock plugins and integrations version by default #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## hotfix/lock-components #1956 +/- ##
==========================================================
+ Coverage 61.30% 61.38% +0.08%
==========================================================
Files 484 484
Lines 16626 16622 -4
Branches 3356 3323 -33
==========================================================
+ Hits 10192 10204 +12
- Misses 5167 5209 +42
+ Partials 1267 1209 -58 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
…t.lock-components-version-sdk-2708
…t.lock-components-version-sdk-2708
…t.lock-components-version-sdk-2708
…t.lock-components-version-sdk-2708
arpl
reviewed
Jan 23, 2025
arpl
approved these changes
Jan 23, 2025
arpl
reviewed
Jan 23, 2025
ChryssaAliferi
approved these changes
Jan 23, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I've deprecated the
lockIntegrationsVersionandlockPluginsVersionload API options as the SDK will load the integrations and plugins from the versioned directories by default now.Even in the case of when user provides the paths for these components, the major version (
/v3) will be replaced with the exact version of the core SDK.Additionally, the core SDK script tag will be identified using the dataset attribute first before using the fallback option.
The deployment workflow has been updated with the following changes:
/v3). They are published only to the versioned directories.Linear task (optional)
https://linear.app/rudderstack/issue/SDK-2708/namespace-the-dynamically-loaded-sdk-artifacts-with-a-release-tag
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security