Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature test environment #31

Merged
merged 23 commits into from
Feb 29, 2024
Merged

Conversation

ftorradeflot
Copy link
Contributor

Covering issue #29

This PR contains the code and documentation to be able to launch the extension together with the Rucio development cluster with a specific version

Copy link
Contributor

@garciagenrique garciagenrique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @ftorradeflot !
Here I leave some comments, I would like to test the test env soon to add more relevant ones !

.github/actions/setup/action.yml Show resolved Hide resolved
.github/actions/build-ext/action.yml Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
docker/container/README.md Show resolved Hide resolved
setup.py Show resolved Hide resolved
Copy link
Contributor

@garciagenrique garciagenrique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine to me and works ! Very good job @ftorradeflot ! Bravo !

@ftorradeflot ftorradeflot merged commit dc1395d into rucio:master Feb 29, 2024
1 check passed
@ftorradeflot ftorradeflot linked an issue Feb 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement testing framework to inspect extension working correctly
2 participants