Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spellchecking check to CI (test PR to see if it fails when typos exist) #425

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rdimaio
Copy link
Contributor

@rdimaio rdimaio commented Dec 17, 2024

No description provided.

@rdimaio
Copy link
Contributor Author

rdimaio commented Dec 20, 2024

Works now, but it doesn't automatically pick up the configuration from the config file. There's currently no way to pass this file to the action, so we have 3 options:

  1. pass the options from the config file into the GH actions as arguments (downside to this: we need to manually keep the config and the GH action workflow in sync)
  2. use pre-commit.ci (probably the most convenient solution, but not sure if we want to rely on an external framework for this)
  3. wait for the 'pass configuration' feature to be merged into the GH action. There was a PR from a few years ago but it wasn't merged due to some conflicts. I've picked it up here Add the config file option and tests codespell-project/actions-codespell#80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant