Draft new contribution guide #245
Conversation
docs/contributing.md
Outdated
| A contribution can be either be a **patch** or **feature**: | ||
| A contribution can be either be included in the **next** major release or the | ||
| ongoing **current** release line, e.g. `release-33` This becomes relevant when | ||
| naming the branches of your contributions (See section 3) so the Rucio maintainers |
There was a problem hiding this comment.
Section 3 of this page? Not sure how to better refer to it :-)
| versions. Hotfix branches are created on demand. Please communicate to the Rucio | ||
| maintainers, if you wish to hotfix a previous release. | ||
| * the **master** branch includes the developments for the next major release. | ||
| * the **release-…** branches include the patch/minor developments of the |
There was a problem hiding this comment.
this sentence is a bit confusing, maybe split?
|
I wonder whether using the placeholder name |
bari12
force-pushed
the
contribution-guide
branch
from
84428f7 to
a234c26
Compare
|
@dchristidis Agreed, I replaced it by |
|
I would have never expected How about we use |
|
I think we have to distinguish two things. In the contribution guide we are abstractly talking about the ongoing release line and the future major release line. To me |
|
Just to add, I don't mind even writing |
bari12
force-pushed
the
contribution-guide
branch
from
a234c26 to
4f6e06b
Compare
|
Pinging this as it looks almost ready to be merged |
| If you have questions, you can reach the development team on our | ||
| [__Mattermost__](mattermost.md) channel. |
There was a problem hiding this comment.
I would point them to the contact us page instead: https://rucio.cern.ch/documentation/contact_us
| ./tools/create-patch-branch <unique issue number> '<short_change_message>' | ||
| ./tools/create-feature-branch <unique issue number> '<short_change_message>' | ||
| ./tools/create-current-branch <unique issue number> '<short_change_message>' | ||
| ./tools/create-next-branch <unique issue number> '<short_change_message>' |
There was a problem hiding this comment.
these scripts are currently still named create-patch-branch and create-feature-branch
No description provided.