Don't include development dependencies in info files #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just manually applied this patch to my server and I can confirm it fixed the issue reported #22 |
segiddins
approved these changes
Jun 20, 2024
Co-authored-by: Samuel Giddins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
#22 -- clients are forced to download (and resolve) development dependencies of gems served with these indexes.
What is your fix for the problem, implemented in this PR?
Filter out development dependencies in the info file. I noticed that this is what RubyGems.org does, for example: https://rubygems.org/info/graphql (doesn't have development_dependencies)
Make sure the following tasks are checked
I noticed that some tests on master are already failing on
rubygems:> 1.3.1-- I didn't attempt to fix those.