Extract generate_index command to rubygems-generate_index gem #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
force-pushed
the
segiddins/new-gem
branch
2 times, most recently
from
296b9b9
to
4306d07
Compare
segiddins
force-pushed
the
segiddins/new-gem
branch
3 times, most recently
from
544e832
to
3fcf6f8
Compare
indirect
approved these changes
Oct 21, 2023
segiddins
force-pushed
the
segiddins/new-gem
branch
4 times, most recently
from
1ab39fb
to
9a9330a
Compare
segiddins
force-pushed
the
segiddins/new-gem
branch
from
9a9330a
to
0140f37
Compare
|
This is now passing on older ruby/rubygems as well... Any objections to me merging this & getting the first version pushed? Then I can rebase rubygems/rubygems#7085 with it pointing at the real gem |
simi
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the set of changes needed from
rubygems/rubygemsmainbranch to function as a standalone gem.I am open to feedback about what the initial version should be.
Pairs with rubygems/rubygems#7085