-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append maintenance status per version #762
Conversation
One possible extension would be to use HTML optgroup elements to group the "maintenance levels". |
@deivid-rodriguez @hsbt Thoughts? cf. rubygems/rubygems#5647 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good idea.
36e49b3
to
14be4c2
Compare
Ok with me, not sure if you plan to implement @olleolleolle's suggestion about html optgroup elements? |
@deivid-rodriguez Thanks. I am slightly inclined to choose Option 2 if we will go with a more notice in the main area (or in the fixed header) by #761. |
To me, option 2 seems easier to understand. |
14be4c2
to
da155df
Compare
Signed-off-by: Takuya Noguchi <[email protected]>
da155df
to
cc9a40d
Compare
Thanks @olleolleolle for the preference! Happy to merge this and to improve the presentation in the main area in #761. |
What was the end-user problem that led to this PR?
A visitor cannot see what version is active while 10 minor versions are listed.
Closes #760
What was your diagnosis of the problem?
Looks good to start with indicating the maintenance status per version rubygems/rubygems#5647.
What is your fix for the problem, implemented in this PR?
Append the maintenance status per version next to each version in the version selector in the versioned man pages.
Previous version of screenshots after the change (only for reference)
Why did you choose this fix out of the possible options?
No other option can be imagine...
Signed-off-by: Takuya Noguchi [email protected]