Add links to dev guides from user guides #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
temporarily deployed
to
bundler-site-tnir-activ-wndzqd
There was a problem hiding this comment.
I think the distinction between "Guides" and "Developer Guides" is not very clear, since many Bundler users will call themselves developers.
Should we instead add a new link to the main list, called "Contributing to Bundler" or "Bundler contributor guidelines" or something like that?
All developer guides, are generated from the main repo, already exist on Web site. Signed-off-by: Takuya Noguchi <[email protected]>
tnir
force-pushed
the
tnir-activate-dev-guides-707
branch
from
83139ab
to
321fbf6
Compare
deivid-rodriguez
temporarily deployed
to
bundler-site-tnir-activ-wndzqd
|
I agree with you that the distinction between "Guides" and "Developer Guides" is not very clear! Let me revert all in the previous commit and just add a link from the latest docs to "Contribution guides" i.e. |
deivid-rodriguez
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
note: also was relevant to #691 but not any more.
What was your diagnosis of the problem?
Links can be added at minimum. All developer guides, generated from the main repo, already exist on Web site.
What is your fix for the problem, implemented in this PR?
Adds a link from the sidebar in each guide (not command references) to the top of contribution and developer guide.
Why did you choose this fix out of the possible options?
https://bundler.io/docs.html, but I skipped it at this moment since they are versioned.Signed-off-by: Takuya Noguchi [email protected]