Include inactive storage locations in csv #5026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you'll probably be asked to add or modify a test for this change. (could probably go in |
|
Hey @napster235 -- a reminder that it's good practice to make a branch, rather than using your main. |
|
Functionality looks good. over to @dorner for tech review. |
Ok, noted. I thought it is ok since I was on my fork. |
|
It's ok -- I have to rename it when I pull it for testing, though, and it could be a pain for you if you are ever wanting to work on two PRs that overlap in time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5003
Description
Type of change
How Has This Been Tested?
Screenshots
With checkbox On
With checkbox Off
