Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reporting categories field to base items #5025

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Add reporting categories field to base items #5025

merged 2 commits into from
Feb 20, 2025

Conversation

coalest
Copy link
Collaborator

@coalest coalest commented Feb 18, 2025 •
edited
Loading

Resolves #5008

Description

Adds reporting_category field to the BaseItem model and backfill it with values.

Type of change

  • Internal (It will be part of a new feature but this PR does not change anything external)

How Has This Been Tested?

Tested the migrations manually. Added specs for the base time callback.

@cielf cielf requested a review from dorner February 18, 2025 20:28
dorner
dorner approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly straightforward. Good job!

@dorner dorner merged commit f20a37c into rubyforgood:main Feb 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorner dorner dorner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding Reporting Categories Step 1 -- Adding fields to base item
2 participants
@coalest @dorner