Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactive Storage Locations should be included in Storage Location export if inactive filter is on #5003

Closed
2 tasks
cielf opened this issue Feb 9, 2025 · 4 comments · Fixed by #5026
Closed
2 tasks
Labels

Comments

@cielf
Copy link
Collaborator

cielf commented Feb 9, 2025

Summary

Include inactive storage locations in the export if they are included in the current filter

Why?

Consistency.

Details

To see the issue,

sign in as [email protected]
click on Inventory, then "Storage Locations.
click the "include inactive storage locations"
click "Filter"
click "Export Storage Locations"
Note that the Inactive Storage Location shows in the main list, but does not show in the export

What should happen

The inactive storage location should appear in the export. (Yes, all the item levels will be 0. )

Criteria for completion

  • Behaviour as described
  • Tests to suppor the behaviour
@napster235
Copy link
Contributor

@cielf I've noticed the same issue on Items & Inventory. Should it be addressed as well?

@cielf
Copy link
Collaborator Author

cielf commented Feb 19, 2025

It should. Do you want to take it on, or shall I just add it to the queue? (Notes that there is an active PR that's touching the export for items atm)

@napster235
Copy link
Contributor

Yes, I can make the change. It is just a view modification. Should I do it on the same PR?

@cielf
Copy link
Collaborator Author

cielf commented Feb 19, 2025

Please make it a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants