Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add max_by #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add max_by #6

wants to merge 2 commits into from

Conversation

lislis
Copy link
Member

@lislis lislis commented Feb 16, 2015

Weird things are happening.
First spec: I don't know how to test for an Enumerator
Last spec: That does not work. Even when I try the example in irb it does not work http://ruby-doc.org/core-2.2.0/Enumerable.html#method-i-max_by :/

@berlintam
Copy link
Contributor

@lislis what version of ruby are you trying this with? something like this:

test = ['hello', 'albert', 'water bottle']
test.max(2)

doesn't seem to work with versions of ruby below 2.2. It looks like the option to add an argument was introduced just recently. Ruby 2.1, for example, doesn't seem to allow this behaviour
http://ruby-doc.org/core-2.1.0/Enumerable.html#method-i-max_by

@lislis
Copy link
Member Author

lislis commented Jun 25, 2015

That's true. We talked about it when we had the respective meeting.

@PragTob
Copy link
Member

PragTob commented Jun 28, 2015

But Ruby 2.2 is DA FUTURRREEEEE 😎

@PragTob
Copy link
Member

PragTob commented Jun 28, 2015

@lislis you could get it back to functionality before and we drop a ruby-version 2.2 and stuff and configure travis that way and then all is good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants