Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Source Sponsors section to our home page #18

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

corsonknowles
Copy link
Contributor

A couple of considerations here:

  1. This is a mild mis-use of the CSS class "people" since these sponsors are not people.
  2. Relatedly, the circle CSS effect is not necessarily ideal in terms of making it easy for staff to upload Sponsor images.

My current thinking is we can solve those issues in future iterations.

Note that we have an entry for "Sentry" on the ghost site, with the new tag added here, so I would expect this to autopopulate on merge and deploy.

A couple of considerations here:
1. This is a mild mis-use of the CSS class "people" since these sponsors are not people. 
2. Relatedly, the circle CSS effect is not necessarily ideal in terms of making it easy for staff to upload Sponsor images. 

My current thinking is we can solve those issues in future iterations.

Note that we have an entry for "Sentry" on the ghost site, with the new tag added here, so I would expect this to autopopulate on merge and deploy.
@corsonknowles corsonknowles marked this pull request as ready for review December 1, 2023 21:37
Copy link
Contributor

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks totally reasonable to me 👍🏻

@indirect indirect merged commit 1f7aa28 into main Dec 1, 2023
1 check passed
@indirect indirect deleted the corsonknowles-patch-1 branch December 1, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants