Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RBS files #151

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Add RBS files #151

merged 4 commits into from
Oct 31, 2024

Conversation

znz
Copy link
Member

@znz znz commented Oct 28, 2024

I add RBS files based on generated files by rbs prototype rb.
And I referred https://github.com/ruby/webrick/blob/fb719152938719deadd21835153b9ed7bd1bb5dc/sig/webrick.rbs for some types.

@hsbt
Copy link
Member

hsbt commented Oct 29, 2024

Can we check these files with GitHub Actions?

@soutaro
Copy link
Member

soutaro commented Oct 30, 2024

It seems like adding gem "rbs", require: false in Gemfile would make sense.

hsbt
hsbt approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@hsbt hsbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hsbt hsbt merged commit 818830b into master Oct 31, 2024
38 checks passed
@hsbt hsbt deleted the add-rbs branch October 31, 2024 06:19
@znz znz mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsbt hsbt hsbt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@znz @hsbt @soutaro