Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug chunk extension detection #125

Merged
merged 5 commits into from
Feb 3, 2024
Merged

Fix bug chunk extension detection #125

merged 5 commits into from
Feb 3, 2024

Commits on Nov 12, 2023

  1. Fix bug chunk extension detection 

    This fixes a request smuggling vulnerability (Fixes ruby#124).

Co-authored-by: Ben Kallus <[email protected]>
    @jeremyevans @kenballus
    jeremyevans and kenballus committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    6018ab9 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Make \r optional in chunk size detection 

    As pointed out by Ken Ballus, WEBrick allows \n without preceding
\r generally.  It probably shouldn't, but since it does, do not
require \r for chunk size detection.
    @jeremyevans
    jeremyevans committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    44cb9cb View commit details
    Browse the repository at this point in the history

  2. Remove unneeded lines in new test

    @jeremyevans
    jeremyevans committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    4ec1194 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Revert "Make \r optional in chunk size detection" 

    This reverts commit 44cb9cb.
    @jeremyevans
    jeremyevans committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    cb6d636 View commit details
    Browse the repository at this point in the history

  2. Reject null bytes in header lines 

    Fixes ruby#126
    @jeremyevans
    jeremyevans committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    dcaeea6 View commit details
    Browse the repository at this point in the history