Update npm package structure #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
katei/restructure-npm-pkg
branch
from
8efa77c to
ffc66c0
Compare
1. Files are now organized as follows to fix ESM imports[^1][^2]:
- `dist/*.cjs.js` -> `dist/cjs/*.js`
- `dist/*.esm.js` -> `dist/esm/*.js`
2. `dist/{cjs,esm}/**/*.js` are now not bundled with rollup to avoid
duplicated bundling.
[^1]: UMD files are kept in the root of `dist/` to avoid breaking
existing code that loads them from CDN instead of `package.json`'s
`exports` field.
[^2]: ESM imports were broken with Node.js because files are not
suffixed with mjs nor `type: module` is not specified in root
`package.json`. Now `dist/esm/package.json` specifies `type: module`.
`dist/esm/browser.js` in `@ruby/wasm-wasi` no longer contains polyfills for Node.js, so we need to bundle them in the version-specific packages.
It would be better to fail the test on uncaught exception compared to timeout.
kateinoigakukun
force-pushed
the
katei/restructure-npm-pkg
branch
from
2c497e3 to
06a03b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dist/*.cjs.js->dist/cjs/*.jsdist/*.esm.js->dist/esm/*.jsdist/{cjs,esm}/**/*.jsare now not bundled with rollup to avoidduplicated bundling.
Footnotes
UMD files are kept in the root of
dist/to avoid breakingexisting code that loads them from CDN instead of
package.json'sexportsfield. ↩ESM imports were broken with Node.js because files are not
suffixed with mjs nor
type: moduleis not specified in rootpackage.json. Nowdist/esm/package.jsonspecifiestype: module. ↩