Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the URL pattern to be replaced in the mock as the npm package is moved. #326

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Modify the URL pattern to be replaced in the mock as the npm package is moved. #326

merged 1 commit into from
Dec 3, 2023
+1 −1

Conversation

ledsun
Copy link
Contributor

@ledsun ledsun commented Dec 2, 2023

The npm package has been moved in #325.
At the same time, the packages referenced in the test code have been fixed.

The pattern of URLs to mock was not fixed.

kateinoigakukun
kateinoigakukun approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@kateinoigakukun kateinoigakukun merged commit e79a70c into ruby:main Dec 3, 2023
@ledsun ledsun deleted the fix_mock_url_pattern branch December 3, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ledsun @kateinoigakukun