Add build support for AWS-LC #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhenium
reviewed
Feb 6, 2025
|
Thanks! The changes look good to me.
Please include those details in the commit message, too. |
samuel40791765
force-pushed
the
aws-lc-support-1
branch
3 times, most recently
from
588c306 to
c850f6e
Compare
rhenium
reviewed
Feb 9, 2025
samuel40791765
force-pushed
the
aws-lc-support-1
branch
from
c850f6e to
edd0533
Compare
CI Changes 1. I've split the original patch up to make it easier to digest, but that forces my hand to turn off testing in the AWS-LC CI for the time being. However, do let me know if you would prefer to review the test adjustments in the same PR and I can remove the temporary CI workaround. 2. AWS-LC has a few no-op functions and we use -Wdeprecated-declarations to alert the consuming application of these. I've leveraged the skip-warnings CI option so that the build doesn't fail. Build Adjustments 1. AWS-LC FIPS mode is decided at compile time. This is different from OpenSSL's togglable FIPS switch, so I've adjusted the build to account for this. 2. AWS-LC does not support for the two KEY_SIG or KEY_EX flags that were only ever supported by old MSIE. 3. AWS-LC has no current support for post handshake authentication in TLS 1.3. 4. EC_GROUP structures for named curves in AWS-LC are constant, static, and immutable by default. This means that the EC_GROUP_set_* functions are essentially no-ops due to the immutability of the structure. We've introduced a new API for consumers that depend on the OpenSSL's default mutability of the EC_GROUP structure called EC_GROUP_new_by_curve_name_mutable. Since Ruby has a bit of functionality that's dependent on the mutability of these structures, I've made the corresponding adjustments to allow things to work as expected.
samuel40791765
force-pushed
the
aws-lc-support-1
branch
from
055efb3 to
e53ec5a
Compare
rhenium
approved these changes
Feb 11, 2025
|
The changes look good to me. Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #833
This contribution is to add basic build support for AWS-LC in the ruby/openssl gem. These changes represent the build portion of a larger patch in the AWS-LC's Ruby integration CI.
CI changes
-Wdeprecated-declarationsto alert the consuming application of these. I've leveraged theskip-warningsCI option so that the build doesn't fail.Build adjustments
KEY_SIGorKEY_EXflags that were only ever supported by old MSIE.EC_GROUPstructures for named curves in AWS-LC are constant, static, and immutable by default. This means thatEC_GROUP_set_*functions are essentially no-ops due to the immutability of the structure. We've introduced a new API for consumers that depend on the OpenSSL's default mutability of theEC_GROUPstructure calledEC_GROUP_new_by_curve_name_mutable. Since Ruby has a bit of functionality that's dependent on the mutability of these structures, I've made the corresponding adjustments to allow things to work as expected.