⚡ Use frozen const when parsing empty arrays #283
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevans
force-pushed
the
parser/frozen-private-EMPTY_ARRAY-const
branch
3 times, most recently
from
fc08916
to
9771e1a
Compare
nevans
force-pushed
the
parser/frozen-private-EMPTY_ARRAY-const
branch
from
9771e1a
to
3b0bed8
Compare
nevans
force-pushed
the
parser/frozen-private-EMPTY_ARRAY-const
branch
from
3b0bed8
to
801b4ae
Compare
nevans
force-pushed
the
parser/frozen-private-EMPTY_ARRAY-const
branch
from
801b4ae
to
090d11a
Compare
TODO, record benchmarks
nevans
force-pushed
the
parser/frozen-private-EMPTY_ARRAY-const
branch
from
090d11a
to
697fde6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Add Net::IMAP::Config class for global and client-scoped config #288
NOTE: this will be considered a breaking change, because some libraries may rely on responses being mutable. (See e.g: #262) The kind thing to do would be to add a config var and a conditional, however that may impact performance... and performance is the primary reason for this PR.
Maybe the(done)mailgem will accept a PR to not mutate search responses?