Ensure consistent Connection header value #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on how you start a connection, the
Connection
header may be unexpectedly set toclose
Creating a new instance of
Net::HTTP
and then calling itsrequest
method (or any of its methods that callrequest
, eg:get
) will first set theConnection
header toclose
(if it's not already set), then start the connection, and re-call itselfWhere as initiating a request with class methods, or by manually starting a connection before calling
request
will not set theConnection
headerAs the default connection in HTTP 1.1 is
keep-alive
, having theConnection
header silently set toclose
is unexpectedExamples:
From what I can see this functionality was added 24 years ago when implicit starts to GET and HEAD requests were introduced. Not long later the shortcut class methods (eg:
Net::HTTP.get
) were added, which calledstart
as part of the method body, bypassing the implicit start therefore not setting theConnection: close
header, creating inconsistent behaviourThis PR stops the
Connection
header from being set toclose
when callingrequest
without an open connection, as that matches the behaviour of the more commonly used class methods, as well as allowing the HTTP 1.1 default ofkeep-alive
to be used unless theConnection
header is explicitly set