-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update #start_with? to match String#start_with signature #444
Conversation
Faraday recently started expecting a string-like #start_with? signature, where you can pass multiple strings to test against and it returns true if any of them passes. We were passing an RDF Value to Faraday since the API was mostly consistent. It seems like the intent is to have the same API as String#start_with?, so this replicates it.
f31418a
to
47192eb
Compare
I don't really know what's going on with the failed CI, some help would be great @gkellogg if you get a chance to look at this. |
Sometimes just rerunning the failed tests fixes it. All green now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an omission from long ago. Are their other method definitions that also need to be touched?
I'm not sure, this was just the one giving us problems in samvera/valkyrie#958 |
That is, in fact, the only such method definition. Thanks for the contribution, I'll get an updated release out including this shortly. |
Faraday recently started expecting a string-like #start_with? signature, where you can pass multiple strings to test against and it returns true if any of them passes. We were passing an RDF Value to Faraday since the API was mostly consistent.
It seems like the intent is to have the same API as String#start_with?, so this replicates it.