Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TruffleRuby version on CI to 23.1.1 (latest) #422

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update TruffleRuby version on CI to 23.1.1 (latest) #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74646e2
Use TruffleRuby 23.1.1 (latest) on CI
andrykonchin Jan 8, 2024
d15c58f
Remove excessive conditions in tests
andrykonchin Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- "3.2"
- "jruby-9.3"
- "jruby-9.4"
- "truffleruby-22"
- "truffleruby-23"
steps:
- uses: actions/checkout@v2
- name: Run tests with Ruby ${{ matrix.ruby }}
Expand Down
4 changes: 2 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ services:
working_dir: /code

# https://github.com/flavorjones/truffleruby/pkgs/container/truffleruby
ci-truffleruby-22:
image: ghcr.io/flavorjones/truffleruby:22.3.1
ci-truffleruby-23:
image: ghcr.io/flavorjones/truffleruby:23.1.1
entrypoint: /code/ci-run.sh
environment:
INTEGRATION: openldap
Expand Down
4 changes: 2 additions & 2 deletions test/test_ssl_ber.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,14 @@ def setup

def test_transmit_strings
omit_if RUBY_PLATFORM == "java", "JRuby throws an error without a real socket"
omit_if (RUBY_VERSION >= "3.1" || RUBY_ENGINE == "truffleruby"), "Ruby complains about connection not being open"
omit_if RUBY_VERSION >= "3.1", "Ruby complains about connection not being open"

assert_equal "foo", transmit("foo")
end

def test_transmit_ber_encoded_numbers
omit_if RUBY_PLATFORM == "java", "JRuby throws an error without a real socket"
omit_if (RUBY_VERSION >= "3.1" || RUBY_ENGINE == "truffleruby"), "Ruby complains about connection not being open"
omit_if RUBY_VERSION >= "3.1", "Ruby complains about connection not being open"

@to.write 1234.to_ber
assert_equal 1234, @from.read_ber
Expand Down