Update README.md with gemspec #355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jethrodaniel
suggested changes
May 13, 2020
There was a problem hiding this comment.
If you're adding development info, you might also want to add something about using bundler as well
git clone https://github.com/ruby-ldap/ruby-net-ldap
cd ruby-net-ldap
gem install bundler # if you don't have it
bundle # or bundle install
bundle exec rake rubotest
In fact, bundler usage is mentioned in CONTRIBUTING.md.
Additionally, gem build ..., is usually followed by gem install ... - or you can use bundler's rake tasks to do that for you (bundle exec rake build, bundle exec rake install).
Also, the changes to lib/net/ldap.rb would be best as another PR.
(cherry picked from commit b54d7b1)
|
Thank you for the feedback @jethrodaniel. Have updated the README as per your suggestions. Will raise separate PRs for the rest of the changes |
jethrodaniel
suggested changes
May 14, 2020
jethrodaniel
suggested changes
May 14, 2020
jethrodaniel
approved these changes
May 14, 2020
jethrodaniel
approved these changes
May 14, 2020
|
👍 thanks |
HarlemSquirrel
requested changes
Jul 6, 2020
| @@ -1315,6 +1316,7 @@ def new_connection | |||
| :hosts => @hosts, | |||
| :encryption => @encryption, | |||
| :instrumentation_service => @instrumentation_service, | |||
| :socket_class => @socket_class, | |||
There was a problem hiding this comment.
Changes to this file should be in a separate PR.
HarlemSquirrel
requested changes
Jul 9, 2020
| @@ -1315,6 +1316,7 @@ def new_connection | |||
| :hosts => @hosts, | |||
| :encryption => @encryption, | |||
| :instrumentation_service => @instrumentation_service, | |||
| :socket_class => @socket_class, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates README.md