Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2529 change the
@setup
variable to an [] but the code is using+=
when adding a new step. This creates a new[]
everytime and its not the best in terms on memory footprint. This PR replaced the+=
by<<
to not create new arrays.I had to remove a test since having duplicates is expected. It would have failed in #2529 if the test had been like this since @setup is not the same object.
Running
benchmark/remounting.rb
shows the efficiency. It shows the difference between a Set and an Array but we still see a difference between<<
and+=
This is currently
This is with the PR