Skip to content

Add danger #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 24, 2025
Merged

Add danger #956

merged 8 commits into from
May 24, 2025

Conversation

numbata
Copy link
Contributor

@numbata numbata commented May 19, 2025

This PR introduces a GitHub Actions workflow that runs Danger with the ruby-grape-danger ruleset on every pull request. It automates checks for CHANGELOG entries, up-to-date README ToC, and other style/doc hygiene, replacing manual reviewer effort.

Closes #955

@numbata numbata marked this pull request as ready for review May 20, 2025 19:32
@dblock
Copy link
Member

dblock commented May 20, 2025

Looks like CI is failing on ruby-head, let's comment it out?

@numbata
Copy link
Contributor Author

numbata commented May 22, 2025

@dblock did it in external PR #958

@dblock
Copy link
Member

dblock commented May 24, 2025

Btw, the way we run danger to comment on PRs requires a token. See ruby-grape/danger#12 if you're bored.

@dblock dblock merged commit 8576390 into ruby-grape:master May 24, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add danger
2 participants