Use route.namespace instead instance_variable_get(@options)
#931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `route_instance_variable_equals?` to `route_namespace_equals?` Refactor route_path_start_with? and route_namespace_equals? with Enumerator instead of static Arrays Refactor determine_namespaced_routes in positive logic (select over reject)
|
thanks @ericproulx … but it's not my gem 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to improve some parts of Grape, I came across an error in your gem since my code had removed
@optionsinGrape::Router::Route. This PR replaces theinstance_variable_getby simply usingroute.namespacewhich is accessible from an instance of Grape::Router::Route.I also refactor some small methods like
route_namespace_equals?by using an Enumerator instead ofifwith interpolation. Ain't a big change but it will lazily interporlate strings if needed.