raising ArgumentError if exposure_options[:using] does not respond to represent #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it. Can you please fix the build (RuboCop) and update CHANGELOG? |
|
Updated the CHANGELOG.md and build is green. |
| exposure_options[:using] = exposure_options[:using].constantize if exposure_options[:using].respond_to? :constantize | ||
|
|
||
| unless exposure_options[:using].respond_to? :represent | ||
| raise ArgumentError, "The value you pass as the using option must respond to represent. It should be a class that inherits from Grape::Entity. [#{exposure_options[:using].inspect}]" |
There was a problem hiding this comment.
Just re-read this. It doesn't have to be a class that inherits Grape::Entity, that is just one possible class. I think it should say something like "#{exposure_options[:using].class} must implement represent.", what do you think?
|
See my comment on the contents of the exception. Also can you squash these commits? Thanks. |
|
Bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current NoMethodError that gets raised requires time to trace and debug. The ArgumentError that is raised now gives a little more information and context to fix the issue quicker.