Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop multijson dependency #385

Merged
merged 2 commits into from
May 10, 2024
Merged

Drop multijson dependency #385

merged 2 commits into from
May 10, 2024

Conversation

ericproulx
Copy link
Contributor

This PR adds a Grape::Entity::Json class that will use multijson if already loaded instead of the default json.

A spec has been added to make sure to_json still works and moved require 'spec_helper' in .rspec file

@ericproulx
Replace Multijson by Grape::Entity::Json
639bc70 
Add require spec_helper in rspec file
Add spec
@ericproulx
Fix rubocop
4d5107e
@ericproulx
Copy link
Contributor Author

@LeFnord If you want to take a look :)

LeFnord
LeFnord reviewed May 8, 2024
View reviewed changes
Copy link
Member

@LeFnord LeFnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ericproulx … only one question

lib/grape_entity/json.rb Show resolved Hide resolved
.rspec Show resolved Hide resolved
LeFnord
LeFnord approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@LeFnord LeFnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ericproulx

@LeFnord LeFnord merged commit d42199e into ruby-grape:master May 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeFnord LeFnord LeFnord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericproulx @LeFnord