Replace references to ActiveRecord::Base with ApplicationRecord
#310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
approved these changes
Feb 6, 2022
README.adoc
Outdated
| @@ -1162,7 +1162,7 @@ end | |||
| # same table you had during the creation of the migration. | |||
| # In future if you override the `Product` class and change the `table_name`, | |||
| # it won't break the migration or cause serious data corruption. | |||
| class MigrationProduct < ActiveRecord::Base | |||
There was a problem hiding this comment.
I'm on the fence with changing it here, and the reason is #284.
Wondering what enhancements could go into ApplicationRecord that would be useful in migrations.
And since those enhancements are a subject to change over time, running historical migrations can be affected by the same issue as with renaming/removing models.
I'd keep this guideline intact, maybe with a clarification.
There was a problem hiding this comment.
I've put this one back to ActiveRecord::Base.
andyw8
force-pushed
the
andyw8/use-application-record
branch
from
3a0975c to
43b7590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changed in Rails 5:
https://www.bigbinary.com/blog/application-record-in-rails-5