Proper handling of errors returned by telegram API #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i haven't check code but seems like a nice addition, is there any way to see what's wrong with building? |
| messageBuilder.append("code: ").append(response.code()); | ||
| messageBuilder.append(", message: ").append(response.message()); | ||
|
|
||
| if(response.body() != null) { |
There was a problem hiding this comment.
are you sure you can do it? shouldn't response.body() be called only once? multiple calls will cause an exception
There was a problem hiding this comment.
and all future or past calls too
There was a problem hiding this comment.
It just returns a value of the body field
This if just a check that body exists and accessing it will not give us an NPE
But the body is a ResponseBody instance and is consumable and should be consumed once
And here I call .string() which consumes body and closes it, so this piece does not require try-with-resources notation
|
@rubenlagus any chance to get it merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polling Bot
Errors from telegram were not logged properly - you never know what exacty telegram wants to tell you
All error details are added to the exception message which is always logged with the stacktrace
In Telegram Client HTTP error codes were not hadled at all -
onFailureis only called on HTTP transport errors (cancellation, a connectivity problem or timeout), HTTP response coded should be handled inonResponseWe only knew about TG API errors by seend parsing exceptions, when error structure could not be pased as an expected java class
Now only 2xx responses are parsed normally, for other responses we gather details and throw an exception