-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gh actions #90
Conversation
Hi, thanks for the contribution. I very much appreciate some help in this area since I'm not a great expert on To be compared with the main site: There are a few issues that I would like to see fixed before pushing to the
Best, Magnus |
That is a great initiative!
Fixed! just removed the logo, as pkgdown adds a logo on the top right by default.
You could remove
It is possible to squash and merge on GitHub. On the merge pull request button, you can select Squash. but I do not mind if my name does not appear, it is a very small contribution. |
I just updated the gh actions to latest. The workflows are now simpler and use pak under the hood. I also added your commits for the favicons |
Co-authored-by: Magnus Thor Torfason <[email protected]>
I added all the changes apart from the actions, after squashing the commits for a cleaner history, see #91. I got an error on the actions, something to do with the caching step, so I decided to postpone them for now. So I'll close this PR, we can do another PR on the |
Sure thing! thanks. happy to answer any more questions if you have some. Cheers |
Also, improve website look.
You can also consider adding favicons using
pkgdown::build_favicons()
.