Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for #86 #87

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Hotfix for #86 #87

merged 2 commits into from
Jan 19, 2024

Conversation

J-Moravec
Copy link
Contributor

This fixes issues of not being able to import classes with dots in their name.

This was actually a bug where sep instead of collapse was used in a vector.

The assumption that the method can't have dot in name remains. Possible fix for that would include looking around for imported generics with dot in name and registering methods for such generics.

In the meantime, there is this hotfix.

@torfason torfason merged commit d269675 into rticulate:dev Jan 19, 2024
5 checks passed
@torfason
Copy link
Collaborator

Thanks for the fix! I've:

  • Verified that the new test reproduces the issue
  • Verified that the updates fixes the issue and the new test
  • Verified that the updates cause no other tests to fail
  • Merged this into both dev and main
  • Updated the version to 1.3.2 and updated the site
  • Sent a new release to CRAN

Hopefully this will show up an CRAN within a day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants