Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions #82

Merged
merged 7 commits into from
Sep 22, 2023
Merged

Fix GitHub Actions #82

merged 7 commits into from
Sep 22, 2023

Conversation

hutch3232
Copy link
Contributor

@hutch3232 hutch3232 commented Sep 19, 2023

To be honest I didn't really know what I was doing and feel I lucked out getting it to pass on the first try. I essentially just updated the action versions. I also added builds for pull requests. Open to any feedback, this was kind of just a test run that happened to (seemingly) work.

edit: spoke too soon, pkgdown failed, but I think that's expected because I don't have necessary permissions on the main repo.

@torfason
Copy link
Collaborator

Great! That really is how this should work, and increasingly does with the more recent versions of the actions and the added benefit of usethis simplifying integration. In other words, when the code is good the CI checks should work without fuss.

I'm sure you are right about the pkgdown scripts, that this is a permissions thing. I can update them to run at the appropriate time (not on PRs and not on all branches) as I finalize the release. The important thing is to have R-CMD-check passing on all platforms and versions. Hoping to get to this by the weekend, will be in touch if I see anything else.

@torfason torfason merged commit 4c28f30 into rticulate:dev Sep 22, 2023
5 of 6 checks passed
@hutch3232 hutch3232 deleted the upd_gh_actions branch September 23, 2023 22:49
@torfason torfason mentioned this pull request Sep 25, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants