Externally defined Init/Idle #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfoHT
force-pushed
the
initidleanywhere
branch
from
5cec489 to
cae4638
Compare
added 2 commits
February 5, 2022 11:47
Tasks can be externally defined, so should idle and init
AfoHT
force-pushed
the
initidleanywhere
branch
from
cae4638 to
ac14402
Compare
|
Review this pr please, it's very important for those who use Clion without proper macro proc. Actually the only way to write code with autocomplete and syntax highlighting. |
Indeed, however there is more work needed in codegen to make this work, this is the first step (the parsing). |
|
TODO: Make sure that the visibility of the shared and local struct is pub if externalized, and propagate it |
|
Commenting to express some interest in this feature. I'm starting to work on some more complicated apps and I'd love to put initialization in a separate module. |
bors bot
added a commit
to rtic-rs/rtic
that referenced
this pull request
Jun 14, 2023
767: allow #[init] and #[idle] to be externed r=korken89 a=wiktorwieclaw I updated `rtic-macros` to a allow init and idle to be externally defined. ## Design notes * Updated `extern_binds` example to include external #[init] and #[idle] functions. * Added docs to Local and Shared structs. The `extern_binds` example has a `#![deny(missing_docs)]` which caused some issues. ## Testing Apart from building the example, I also used this feature in one of my projects and ran it on a MCU [here](https://github.com/grupacosmo/cansat/blob/98ca7bd42e737adfb140a548da1ade01beb495da/crates/cansat-stm32f4/src/main.rs#L59-L74) ## Related issues * #505 ## Related PRs * rtic-rs/rtic-syntax#71 Co-authored-by: Vixu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks support being externally defined, idle and init should too.
rtic-syntax component of fixing rtic-rs/rtic#505