Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt another bind when registering a binding outside a renderHtml() context #3638

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Attempt another bind when registering a binding outside a renderHtml() context #3638

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7bccfeb
Close #3635: attempt another bind when registering a binding outside …
cpsievert May 17, 2022
b023350
Introduce an onRegister() method on BindingRegistry to help solve the…
cpsievert May 23, 2022
d0bf86e
Add a clear() method to Callbacks
cpsievert May 23, 2022
ed12e92
Merge branch 'main' into bindAfterRegister
wch Oct 5, 2022
0fe8040
Merge branch 'main' into bindAfterRegister
wch Jan 6, 2023
0f00ecf
Sync package version (GitHub Actions)
wch Jan 6, 2023
1f752b6
Merge branch 'main' into bindAfterRegister
cpsievert Jan 18, 2023
490803f
Update srcts/src/shiny/init.ts
cpsievert Mar 29, 2023
4702ff4
Update srcts/src/shiny/init.ts
cpsievert Mar 29, 2023
d93136c
lint; yarn build
cpsievert Mar 29, 2023
a1e5514
Merge branch 'main' into bindAfterRegister
cpsievert Mar 29, 2023
91df0b1
Update news
cpsievert Mar 29, 2023
66a9726
Use actionQueue to guarantee bind happens after async rendering has c…
cpsievert Mar 31, 2023
f694e70
Add comment; removing logging
cpsievert Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

* `Map` objects are now initialized at load time instead of build time. This avoids potential problems that could arise from storing `fastmap` objects into the built Shiny package. (#3775)

* Closed #3635: `window.Shiny.outputBindings` and `window.Shiny.inputBindings` gain a `onRegister()` method, to register callbacks that execute whenever a new binding is registered. Internally, Shiny uses this to check whether it should re-bind to the DOM when a binding has been registered. (#3638)

### Bug fixes

* Fixed #3771: Sometimes the error `ion.rangeSlider.min.js: i.stopPropagation is not a function` would appear in the JavaScript console. (#3772)
Expand Down
Loading