refactor: More concise duplicateIds typing

Co-authored-by: Nick Strayer <[email protected]>
rstudio · Nov 30, 2023 · 76abdca · 76abdca
1 parent 1c0c4c3
commit 76abdca
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/srcts/src/shiny/bind.ts b/srcts/src/shiny/bind.ts
@@ -72,15 +72,9 @@ const bindingsRegistry = (() => {
   function checkValidity():
     | { status: "error"; error: ShinyClientError }
     | { status: "ok" } {
-    const duplicateIds: Map<string, { input: number; output: number }> =
-      new Map();
-
-    const countBindingType = (
-      types: BindingTypes[],
-      bindingType: BindingTypes
-    ) => {
-      return types.filter((type) => type === bindingType).length;
-    };
+    type BindingCounts = { [T in BindingTypes]: number };
+    const duplicateIds = new Map<string, BindingCounts>();
+
 
     // count duplicate IDs of each binding type
     bindings.forEach((idTypes, id) => {