Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add first version of the CVPR rticle model #278

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

DunLug
Copy link
Contributor

@DunLug DunLug commented Mar 8, 2020

Hi, I've began to create a template for the CVPR conference's stylesheet (see http://cvpr2020.thecvf.com/submission/main-conference/author-guidelines#submission-guidelines).
It's a work in progress, I created this pull request to ask questions if necessary and to avoid somebody to make this work twice.

TODO List:

  • Harmonize the API to be similar to other papers
  • Check that resulting documents are compliant with the rules
  • Create a good example file
  • Sign the contributor agreement
  • Add the journalname_article() function to R/article.R if the output format is simple enough, otherwise create a separate R/journalname_article.R.
  • Add the Pandoc LaTeX template inst/rmarkdown/templates/journalname_article/resources/template.tex.
  • Add a skeleton article inst/rmarkdown/templates/journalname_article/skeleton/skeleton.Rmd.
  • Add a description of the template inst/rmarkdown/templates/journalname_article/template.yaml.
  • Please include the document class file (*.cls) if needed, but please do not include standard LaTeX packages (*.sty) that can be downloaded from CTAN. Please keep the number of new files absolutely minimal, and also make examples minimal (e.g., if you need a .bib example, try to only leave one or two bibliography entries in it, and don't include one hundred items in it without using all of them).
  • Update Rd and namespace (could be done by devtools::document()).
  • Update NEWS.
  • Update README with a link to the newly supported journal.
  • Add a test to tests/testit/test-formats.R.
  • Add your name to the list of authors Authors@R in DESCRIPTION. You don't need to bump the package version in DESCRIPTION.

Issues

About the document usage, I don't understand how to tell knitr to search sty files inside the inst folder. I checked it in acm_article example but it doesn't seems to work either.

@yihui yihui requested a review from cderv August 3, 2020 21:55
@cderv
Copy link
Collaborator

cderv commented Aug 6, 2020

@DunLug where are you on this PR ?
I see that there is some unchecked boxes on your todolist. Do you plan on finishing it ?

In the meantime, if it is not yet ready for review, how about converting if to a draft PR ? You'll then change the status when ready to be reviewed so we know when to look

Thank you !

@DunLug
Copy link
Contributor Author

DunLug commented Aug 6, 2020

Hi @cderv,
I'm really sorry I forgot about this pull request.
I'm currently finishing my thesis so I don't think I'll be able to work on it for now, so I convert it to a draft PR and update it after my PhD is done.
Thanks for your message

@DunLug DunLug marked this pull request as draft August 6, 2020 10:08
@cderv cderv removed their assignment Aug 6, 2020
@cderv
Copy link
Collaborator

cderv commented Aug 6, 2020

That is ok. Thank you !
We hope you'll find time to finish it. Cheers!

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ cderv
❌ DunLug
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I just have updated the branch with last change from our master. This will allow you to start on better basis for next time you'll find time to finish this contribution.

Thank you !

@@ -6,6 +6,8 @@

- Add `trb_article()` for annual meeting submissions to the Transportation Research Board Annual Meeting (thanks, @gregmacfarlane, #427).

- Added cvpr_article() document class
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Added cvpr_article() document class
- Added `cvpr_article()` output format for conference paper (thanks, @DunLug, #278).

@cderv
Copy link
Collaborator

cderv commented Apr 19, 2023

👋 @DunLug - gettting back to you on this for a status update

I'm currently finishing my thesis so I don't think I'll be able to work on it for now, so I convert it to a draft PR and update it after my PhD is done.

Is this PR still a project you want to finish ? No pressure, just wants to known where we are at

@cderv cderv added the WIP label Apr 19, 2023
@DunLug
Copy link
Contributor Author

DunLug commented May 4, 2023

Hi, @cderv,
I kept this project in my list but found no time. Maybe this PR can be archived for now. I think it's better to create a new merge request when I'll have time to really update the code.

@cderv
Copy link
Collaborator

cderv commented May 4, 2023

I passed it to draft. When you have time (or someone else), this one can be rebased, or closed and a new one started. Thanks for the reply

@cderv cderv added the help wanted ❤️ we'd love your help! label May 4, 2023
@cderv cderv mentioned this pull request May 4, 2023
@cderv cderv linked an issue May 4, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted ❤️ we'd love your help! WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a CVPR template
3 participants