Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenMind article template #194

Closed
wants to merge 17 commits into from
Closed

Add OpenMind article template #194

wants to merge 17 commits into from

Conversation

mikabr
Copy link

@mikabr mikabr commented Nov 9, 2018

This adds an rticles::opmi_article() template based on the OpenMind LaTeX template.

Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR actually contains three article formats. Is it possible split them into three separate PRs? That will make code review a little easier. If not, I guess I'll have to bit the bullet someday anyway... 😭

@mikabr
Copy link
Author

mikabr commented Mar 20, 2019

sorry about that, will fix when I get a chance

@yihui
Copy link
Member

yihui commented Mar 20, 2019

No worries. Thanks!

@yihui yihui force-pushed the master branch 3 times, most recently from 033a19f to d98786f Compare August 20, 2019 20:57
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go through the PR requirements at https://github.com/rstudio/rticles/blob/master/.github/PULL_REQUEST_TEMPLATE.md and try to fix some issues first (e.g. perhaps skeleton.pdf shouldn't be included). Thank you!

@mikabr mikabr closed this Aug 4, 2020
@mikabr
Copy link
Author

mikabr commented Aug 4, 2020

I redid the PR cleanly with #305 because this one was so messy

@yihui
Copy link
Member

yihui commented Aug 5, 2020

Thank you very much!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants