Fix builds on macOS #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a few compatibility cases and allows the project to be built on macOS: * Define HOST_NAME_MAX to its POSIX equivalent if not present. * Gate calls to ptrctl(), which is a Linux-specific syscall. * Include <signal.h>, which is the canonical header for kill(). * Use C++17, which is required for our use of weak_for_this() when building with Clang. macOS builds are useful for testing with the smoke-test tool; obviously the Launcher itself does not run on macOS. Signed-off-by: Aaron Jacobs <[email protected]>
|
Nice to see, thanks! Heads up @nahara7 and @bschwedler |
|
@kfeinauer Do you foresee any issues with updating the C++ standard used? |
|
We will need to check the compatibility matrices of our supported operating systems to make sure that their version of GCC supports C++17. My gut feeling is that there is likely a supported OS that is too old. We could modify this PR to conditionally set the standard just for macOS builds, otherwise. |
|
That sounds right to me. A slightly more generic approach may be to test whether |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few compatibility cases and allows the project to be built on macOS:
Define
HOST_NAME_MAXto its POSIX equivalent if not present.Gate calls to
ptrctl(), which is a Linux-specific syscall.Include
<signal.h>, which is the canonical header forkill().Use C++17, which is required for our use of
weak_for_this()when building with Clang.macOS builds are useful for testing with the smoke-test tool; obviously the Launcher itself does not run on macOS.