Skip to content

Commit

Permalink
Fix image short sha (#760)
Browse files Browse the repository at this point in the history
* Add debug statement for git rev-parse

* Use github.sha instead of HEAD

* Set GIT_SHA to null

* Add debug plan

* Fix output for GIT_SHA

* Remove debug statement
  • Loading branch information
ianpittwood committed May 8, 2024
1 parent 46bf105 commit 75b9818
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/build-bake.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
cancel-in-progress: true

outputs:
GIT_SHA: ${{ steps.checkout.outputs.sha }}
GIT_SHA: ${{ steps.get-git-sha.outputs.GIT_SHA }}

steps:
- name: Checkout
Expand All @@ -29,6 +29,7 @@ jobs:
run: |
GIT_SHA=$(git rev-parse --short HEAD)
echo "GIT_SHA=$GIT_SHA" >> $GITHUB_OUTPUT
echo "$GIT_SHA"
base:
needs: [setup]
Expand Down
2 changes: 1 addition & 1 deletion docker-bake.hcl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ variable DEFAULT_JUPYTERLAB_VERSION {
}

variable GIT_SHA {
default = ""
default = null
}

function tag_safe_version {
Expand Down

0 comments on commit 75b9818

Please sign in to comment.