Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mounted router fall back to parent router when route is not found #883

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Mounted router fall back to parent router when route is not found #883

wants to merge 18 commits into from

Commits on Sep 28, 2022

  1. Static routes should return a forward if a path isn't found

    @schloerke
    schloerke committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    aa7ecd1 View commit details
    Browse the repository at this point in the history

  2. Add a routeNotFound() sentinel value and is helper

    @schloerke
    schloerke committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    90090a5 View commit details
    Browse the repository at this point in the history

  3. All mounts will fall through to the next possible route. Need opt out/in

    @schloerke
    schloerke committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    b935b56 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Instead of counter, use flag and restore previous value 

    Hides how many mounts are being used
    @schloerke
    schloerke committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    1c36111 View commit details
    Browse the repository at this point in the history

  2. Test mount falling back to parent mount

    @schloerke
    schloerke committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    3f1cc4c View commit details
    Browse the repository at this point in the history

  3. Remove mount count setup

    @schloerke
    schloerke committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    a8565e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Move route not found handling to $serve() instead of $route(); Al… 

    …lows for top router to handle 404s
    @schloerke
    schloerke committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    72e2e9a View commit details
    Browse the repository at this point in the history

  2. Add better return value

    @schloerke
    schloerke committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    8a4bf10 View commit details
    Browse the repository at this point in the history

  3. If a route was handled, do not return 404.

    @schloerke
    schloerke committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    45aca33 View commit details
    Browse the repository at this point in the history

  4. Only add mount steps if they are used. Allow for async mount route ha… 

    …ndling
    @schloerke
    schloerke committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    532d225 View commit details
    Browse the repository at this point in the history

  5. Make sure mounts can be async

    @schloerke
    schloerke committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    2cc08d1 View commit details
    Browse the repository at this point in the history

  6. Update tests to work with new mount fall through logic

    @schloerke
    schloerke committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    885c598 View commit details
    Browse the repository at this point in the history

  7. Use the req$pr instead of self in case code is moved else where

    @schloerke
    schloerke committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    387a041 View commit details
    Browse the repository at this point in the history

  8. Revert "Use the req$pr instead of self in case code is moved else… 

    … where"

This reverts commit 387a041.
    @schloerke
    schloerke committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    a70e056 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Set default 404 handler to routeNotFound(); Keep old 404 handler as… 

    … last resort in `$serve()`
    @schloerke
    schloerke committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    ab3973a View commit details
    Browse the repository at this point in the history

  2. Add lastChanceRouteNotFound() method for when mount 404 method is f… 

    …ound.

In `$serve()`, move `routeNotFoundStep` before `postRouteStep`
In `$route()`, if `404` handler has been set, call `lastChanceRouteNotFound()`
    @schloerke
    schloerke committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    f931f9e View commit details
    Browse the repository at this point in the history

  3. Wish we had finally() support

    @schloerke
    schloerke committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    ab497fe View commit details
    Browse the repository at this point in the history

  4. Create route_execution.md

    @schloerke
    schloerke committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    4ce3538 View commit details
    Browse the repository at this point in the history