Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/262-add-rdata-dep #265

Merged
merged 16 commits into from
Dec 17, 2024
Merged

Feature/262-add-rdata-dep #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5b20f43
Add rdata as a dependency
nathanjmcdougall Jul 22, 2024
6acd130
Don't explicitly install rdata an extra time.
nathanjmcdougall Jul 22, 2024
bb884af
Revert removal of `[test]` in cases where it is still needed.
nathanjmcdougall Jul 22, 2024
473a3d1
Add read_rds workaround for rdata on Python 3.8.
nathanjmcdougall Jul 23, 2024
45d1ce5
Remove `hasattr` check
nathanjmcdougall Jul 24, 2024
0c503aa
Add type conversion for 3.8 support of rds load
nathanjmcdougall Aug 20, 2024
1439fec
Use f.name for 3.8 rdata call
nathanjmcdougall Aug 21, 2024
4899331
Use f.name rather than type conversion.
nathanjmcdougall Aug 21, 2024
534a1ea
Enable `reportMissingImports` in pyright
nathanjmcdougall Aug 21, 2024
c021871
Isolate protected import for pyright
nathanjmcdougall Aug 21, 2024
4dd2274
Disable pyright for protected optional import
nathanjmcdougall Aug 21, 2024
159ec96
Fix typo 🤦‍♂️
nathanjmcdougall Aug 21, 2024
6d7d9de
Merge branch 'main' into dev-262
isabelizimm Dec 16, 2024
13ada20
dropped 3.8, no longer need workaround
isabelizimm Dec 16, 2024
b7d36cf
Merge branch 'main' into feature/262-add-rdata-dep
nathanjmcdougall Dec 16, 2024
2353a43
Merge branch 'main' into feature/262-add-rdata-dep
isabelizimm Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,7 @@ jobs:
run: |
python -m pip install --upgrade pip
python -m pip install -r requirements/dev.txt
python -m pip install rdata
python -m pip install -e .[test]
python -m pip install -e .

- name: run Posit Connect
run: |
Expand Down
2 changes: 1 addition & 1 deletion pins/drivers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def load_data(

elif meta.type == "rds":
try:
import rdata
import rdata # pyright: ignore[reportMissingImports]

return rdata.read_rds(f)
except ModuleNotFoundError:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ test = [
"pytest-dotenv",
"pytest-parallel",
"s3fs",
"rdata",
]

[build-system]
Expand Down Expand Up @@ -102,7 +103,6 @@ reportArgumentType = false
reportAttributeAccessIssue = false
reportCallIssue = false
reportIncompatibleMethodOverride = false
reportMissingImports = false
reportMissingTypeStubs = false
reportOptionalMemberAccess = false
reportOptionalSubscript = false
Expand Down
4 changes: 4 additions & 0 deletions requirements/dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,8 @@ pyzmq==26.2.0
# jupyter-client
quartodoc==0.9.1
# via pins (pyproject.toml)
rdata==0.11.2
# via pins (pyproject.toml)
referencing==0.35.1
# via
# jsonschema
Expand Down Expand Up @@ -442,6 +444,8 @@ wheel==0.45.1
# via pip-tools
wrapt==1.17.0
# via aiobotocore
xarray==2024.6.0
# via rdata
xxhash==3.5.0
# via pins (pyproject.toml)
yarl==1.18.3
Expand Down
Loading