Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chronicle version to 2024.09.0 #543

Closed
wants to merge 15 commits into from
Closed

Conversation

matt-urbina
Copy link
Contributor

Background

Part of the Chronicle release described here: https://github.com/rstudio/chronicle/issues/1067. The Chronicle team has made a new code release and we're updating our helm to match.

Summary

Updates Chronicle server values
Update our docs
Update the Connect/Workbench/PPM CI files to match these Chronicle updates
This requires bumping up the chart versions for Connect/Workbench/PPM as well

@matt-urbina matt-urbina changed the title update chronicle version to 2024.09.0 Update chronicle version to 2024.09.0 Sep 4, 2024
@matt-urbina matt-urbina marked this pull request as ready for review September 4, 2024 19:31
Copy link
Contributor

@markrtucker markrtucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we obviously can't merge this until we promote the release

@@ -1,6 +1,6 @@
# Posit Connect

![Version: 0.7.6](https://img.shields.io/badge/Version-0.7.6-informational?style=flat-square) ![AppVersion: 2024.08.0](https://img.shields.io/badge/AppVersion-2024.08.0-informational?style=flat-square)
![Version: 0.7.7](https://img.shields.io/badge/Version-0.7.7-informational?style=flat-square) ![AppVersion: 2024.08.0](https://img.shields.io/badge/AppVersion-2024.08.0-informational?style=flat-square)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not 0.7.8? I would expect this to have the latest version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should, there was a bit of messiness with the merge, Im trying to work through that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why the diff here isn't showing main but the diff from the original commits. I used vscode to do the merge and am not liking the result. Debating blowing this away and getting a clean Branch & PR

Comment on lines +6 to +9
## 0.7.7

- Add helm values for `pod.hostAliases` and `launcher.templateValues.pod.hostAliases`
- Add helm values for `launcher.defaultInitContainer.resources`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused here - this change is already on main. Why is this included in the PR?

@matt-urbina
Copy link
Contributor Author

Closing this PR and creating a new one, some issues when merging using VS Code UI

@matt-urbina matt-urbina deleted the chronicle-2024.09.0 branch September 12, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants