-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connect: update content images and enable quarto by default #486
Conversation
@aronatkins, I think enabling Quarto by default in the config is not breaking anything, but I wanted to check with you. Without it the environments all show Quarto as None by default. |
Quarto is currently different from R/Python in that it can be enabled without a configured executable. At some point, we probably want all three R/Python/Quarto to behave more similarly (warn if enabled without executable). |
@dbkegley I am nervous to put in hardcoded paths for Python and Quarto for non OHE since they need to be updated. When it was in PPM like that and they didn't get updated when the images changed, the charts would break. If the Connect team has a process to update when the images changed then it would make sense but want to make sure that is in place first. |
Appreciate the caution. I'll create a followup for the Connect team to find a way to flag this. I think having an GHA in this repo would be a nice addition to our pre-release testing |
@dbkegley Okay I made the changes, now setting Python and Quarto directly in the default config section of the values.yaml and removed the conditional launcher only logic. One thing I wanted to check on is whether the Executables defined for Quarto and Python are ignored in OHE (is there any harm in having them in there in the values?). Or do you think its cleaner to still have conditional logic where when in OHE we omit those Executable lines? |
Good point. If OHE is enabled then any executables defined in the default |
Connect: Enable Quarto and Python by default for local execution
Co-authored-by: David <[email protected]>
@dbkegley I changed the comments in values.yaml to make it clear that the executables do not apply for OHE and linked to the docs. I retested and things look good to me. I think this is ready when you want to merge (not sure who else should take a look). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think this is good to merge anytime.
I'll be updating the quarto version during the next Connect release which is happening.. soon ™️ so we'll get some mileage out of the new GHA right away. The new checks should fail when we update the image during the release.
default-runtime.yaml
anddefault-runtime-pro.yaml
files created via this PR: modernize content image versions rstudio-docker-products#737Quarto
andPython
in the defaultvalues.yaml
config
section so Python and Quarto content will work out of the box for local execution or off-host execution (closes Add quarto to default Connect config #463). Previously Python was automatically enabled only when launcher was enabled. This conditional is removed now that its in the values.Testing
Deployed Connect into EKS using base and pro, they show up as expected and content can be deployed from R and Python (tested on the content-pro:r4.2.3-py3.11.9-ubuntu2204 image).
Base env list:

Pro env list:
