Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use R and Python image default paths #402

Closed
wants to merge 5 commits into from
Closed

Conversation

ianpittwood
Copy link

No description provided.

@ianpittwood ianpittwood marked this pull request as ready for review July 31, 2023 20:32
Copy link
Contributor

@colearendt colearendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM - just a few questions about the scope of the change / effect on users.

charts/rstudio-pm/Chart.yaml Show resolved Hide resolved
examples/rbac/rstudio-launcher-rbac-0.2.17.yaml Outdated Show resolved Hide resolved
charts/rstudio-connect/ci/complex-values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@bschwedler bschwedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would supersede #371 while also future-proofing against later version updates.

My only concern is making sure that this doesn't break with the existing 2023.04.0 images that are the default and do not have the symlink. We saw that pointing this to a non-existent R version results in a CrashBackoffLoop.

charts/rstudio-pm/NEWS.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bschwedler bschwedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamEdwardes
Copy link
Contributor

We can close this PR. A more flexible solution was merged via #474.

@SamEdwardes SamEdwardes deleted the use-r-py-default-path branch March 12, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants