-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use R and Python image default paths #402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM - just a few questions about the scope of the change / effect on users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would supersede #371 while also future-proofing against later version updates.
My only concern is making sure that this doesn't break with the existing 2023.04.0
images that are the default and do not have the symlink. We saw that pointing this to a non-existent R version results in a CrashBackoffLoop
.
45ca42f
to
bfd4a53
Compare
71042c5
to
7bc8448
Compare
Update helm-docs and README.md Update rbac yaml
Update helm-docs and README.md
This reverts commit ac6c501. Update helm-docs and README.md Update rbac yaml
fc06ad0
to
549ee51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We can close this PR. A more flexible solution was merged via #474. |
No description provided.