Connect release 2023.07.0 #399
Conversation
dethmasque
requested review from
christierney,
colearendt,
zackverham and
nihara-thomas
| @@ -0,0 +1,88 @@ | |||
| --- | |||
There was a problem hiding this comment.
Should we be including a launcher rbac example in this PR?
IIRC these examples files are generated automatically from charts/rstudio-launcher-rbac
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry, confused repos yet again.
Note: The helm-docs job in CI takes care of updating the helm chart version in the README. See example commit from the actions-user bot.
Not sure why the bot edited more than the README?
There was a problem hiding this comment.
This is the workflow: https://github.com/rstudio/helm/actions/runs/5685442795/workflow#L65
There was a problem hiding this comment.
And the run that committed the rbac change: https://github.com/rstudio/helm/actions/runs/5685429289/job/15410307455
There was a problem hiding this comment.
oh! I missed that it was from the bot commit.
@colearendt It looks like rstudio-launcher-rbac.yaml is no longer being kept up to date with the latest rbac example version (0.2.17), is that intentional?
There was a problem hiding this comment.
I think this was just a miss on a recent PR (i.e. we didn't regenerate b/c it was a PR from a fork). Should be fine to just merge it, I believe 😄
|
@colearendt can you give this an approval? Because of the example rbac being included, connect codeowners aren't sufficient |
Included a blurb from this PR dc60d55 that was missing NEWS patch version bump.