Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use setup-helm@v3 from @v1 for updated node and avoid set-output warnings #395

Merged
merged 1 commit into from
Jul 10, 2023
Merged

use setup-helm@v3 from @v1 for updated node and avoid set-output warnings #395

merged 1 commit into from
Jul 10, 2023

Conversation

aronatkins
Copy link
Collaborator

No description provided.

@aronatkins aronatkins requested a review from Lytol July 10, 2023 18:53
@CLAassistant
Copy link

CLAassistant commented Jul 10, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Lytol
Lytol approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@Lytol Lytol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You have a new GH actions warning, but don't need to resolve here IMO.

@aronatkins
Copy link
Collaborator Author

@Lytol - what workflow is emitting a warning? not seeing it ...

@Lytol
Copy link
Contributor

Lytol commented Jul 10, 2023

@Lytol - what workflow is emitting a warning? not seeing it ...

image

@colearendt
Copy link
Member

I think linting suggestions like that are optional 😄

colearendt
colearendt approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@colearendt colearendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@aronatkins
Copy link
Collaborator Author

IGNORING THE LINT WARNING FOR REASONS.

@aronatkins aronatkins merged commit 6275533 into main Jul 10, 2023
8 checks passed
@aronatkins aronatkins deleted the aron-update-setup-helm branch July 10, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lytol Lytol Lytol approved these changes

@colearendt colearendt colearendt approved these changes

@atheriel atheriel Awaiting requested review from atheriel atheriel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aronatkins @CLAassistant @Lytol @colearendt