Service account labels #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstudio-library rbac can now consume serviceAccountLabels
rstudio-workbench/templates/rbac.yaml work with serviceAccountLabels
rstudio-connect works with serviceAccountLabels
rstudio-launcher works with serviceAccountLabels
|
|
|
@colearendt what steps are required to move forward with this? |
|
Content and approach looks fine to me, but I'll defer to Cole on fixing CI. |
|
This looks great! Thanks so much for the submission! Hoping to get to this sometime this week as I keep catching up from vacation 😄 |
colearendt
requested review from
aronatkins,
dbkegley,
christierney and
zackverham
as code owners
colearendt
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #391
Allows one to assign labels in service accounts in rstudio-workbench and rstudio-connect charts.